chore: remove setcfg & transfer ownership#22505
Conversation
# Conflicts: # deployment/ccip/changeset/cs_orchestrate_changesets_test.go # deployment/ccip/changeset/solana_v0_1_1/transfer_ccip_to_mcms_with_timelock_test.go # deployment/ccip/changeset/testhelpers/test_helpers_solana_v0_1_0.go # deployment/ccip/changeset/testhelpers/test_helpers_solana_v0_1_1.go # deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e.go # deployment/ccip/changeset/v1_6/cs_add_registry_module_test.go # deployment/ccip/changeset/v1_6/cs_deploy_chain_test.go # deployment/ccip/changeset/v1_6/cs_deploy_registry_module_test.go # deployment/ccip/shared/stateview/state_test.go # deployment/common/changeset/deploy_mcms_with_timelock_test.go # deployment/common/changeset/example/link_transfer_test.go # deployment/common/changeset/example/solana_transfer_mcm_test.go # deployment/common/changeset/mcms_firedrill_test.go # deployment/common/changeset/set_config_mcms_test.go # deployment/common/changeset/solana/setup_test.go # deployment/common/changeset/transfer_to_mcms_with_timelock_test.go # deployment/common/proposalutils/propose_test.go # deployment/cre/capabilities_registry/v2/changeset/configure_capabilities_registry_test.go # deployment/cre/capabilities_registry/v2/changeset/multiple_mcms_test.go # deployment/cre/mcms/changeset/deploy.go # deployment/cre/workflow_registry/v2/changeset/fixture_test.go # deployment/data-feeds/changeset/accept_ownership_test.go # deployment/data-feeds/changeset/confirm_aggregator_test.go # deployment/data-feeds/changeset/new_feed_with_proxy_test.go # deployment/data-feeds/changeset/propose_aggregator_test.go # deployment/data-feeds/changeset/remove_dataid_proxy_mapping_test.go # deployment/data-feeds/changeset/remove_feed_config_test.go # deployment/data-feeds/changeset/remove_feed_test.go # deployment/data-feeds/changeset/set_bundle_feed_config_test.go # deployment/data-feeds/changeset/set_feed_admin_test.go # deployment/data-feeds/changeset/set_feed_config_test.go # deployment/data-feeds/changeset/update_data_id_proxy_test.go # deployment/keystone/changeset/accept_ownership_test.go # deployment/keystone/changeset/test/env_setup.go # deployment/vault/changeset/batch_native_transfer_test.go # deployment/vault/view/view_test.go
# Conflicts: # system-tests/lib/go.mod
# Conflicts: # deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e.go # deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e_test.go # integration-tests/smoke/ccip/ccip_add_chain_e2e_test.go
# Conflicts: # deployment/ccip/changeset/cs_orchestrate_changesets_test.go # deployment/ccip/changeset/v1_5/cs_rmn.go # deployment/ccip/changeset/v1_5_1/commonconfig.go # deployment/ccip/changeset/v1_5_1/cs_configure_token_pools.go # deployment/ccip/changeset/v1_5_1/cs_propose_admin_role.go # deployment/ccip/changeset/v1_5_1/cs_sync_usdc_domains_with_chains.go # deployment/ccip/changeset/v1_5_1/cs_transfer_admin_role.go # deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e.go # deployment/ccip/changeset/v1_6/cs_chain_contracts.go # deployment/ccip/changeset/v1_6/cs_home_chain.go # deployment/ccip/changeset/v1_6/cs_migration_from_v1_5.go # deployment/ccip/changeset/v1_6/cs_rmn_curse_uncurse.go # deployment/ccip/changeset/v1_6/cs_update_bidirectional_lanes.go # deployment/common/changeset/deploy_mcms_with_timelock.go # deployment/common/changeset/example/link_transfer_test.go # deployment/common/changeset/set_config_mcms_test.go # deployment/common/changeset/transfer_to_mcms_with_timelock_test.go # deployment/common/proposalutils/propose_test.go # deployment/vault/changeset/batch_native_transfer_test.go # integration-tests/smoke/ccip/ccip_add_chain_e2e_test.go # integration-tests/smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go
# Conflicts: # deployment/common/changeset/mcms_firedrill.go # deployment/common/changeset/mcms_firedrill_test.go
# Conflicts: # deployment/ccip/changeset/testhelpers/test_helpers_aptos.go
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
✅ No conflicts with other open PRs targeting |
|
# Conflicts: # deployment/ccip/changeset/crossfamily/cs_set_token_transfer_fee_config_test.go # deployment/ccip/changeset/cs_orchestrate_changesets.go # deployment/ccip/changeset/v1_5_1/cs_add_token_e2e.go # deployment/ccip/changeset/v1_5_1/cs_set_token_transfer_fee_config_test.go # deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e.go # deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e_test.go # deployment/ccip/changeset/v1_6/cs_migration_from_v1_5.go # deployment/ccip/changeset/v1_6_2/cs_configure_cctp_message_transmitter_proxy.go # deployment/ccip/operation/evm/v1_6/ops_rmnremote.go # deployment/ccip/sequence/evm/v1_6/seq_rmn.go # deployment/ccip/shared/stateview/state.go # deployment/ccip/shared/stateview/state_test.go # deployment/common/changeset/deploy_mcms_with_timelock_test.go # deployment/common/changeset/set_config_mcms.go # deployment/common/changeset/set_config_mcms_test.go # deployment/common/changeset/transfer_to_mcms_with_timelock.go # deployment/common/changeset/transfer_to_mcms_with_timelock_test.go # deployment/common/opsutils/evm_test.go # deployment/common/proposalutils/propose_test.go # deployment/cre/contracts/contracts_test.go # deployment/data-feeds/changeset/confirm_aggregator_test.go # deployment/data-feeds/changeset/new_feed_with_proxy_test.go # deployment/data-feeds/changeset/propose_aggregator_test.go # deployment/data-feeds/changeset/remove_dataid_proxy_mapping_test.go # deployment/data-feeds/changeset/remove_feed_config_test.go # deployment/data-feeds/changeset/remove_feed_test.go # deployment/data-feeds/changeset/set_bundle_feed_config_test.go # deployment/data-feeds/changeset/set_feed_admin_test.go # deployment/data-feeds/changeset/set_feed_config_test.go # deployment/data-feeds/changeset/update_data_id_proxy_test.go # deployment/keystone/changeset/accept_ownership.go # deployment/keystone/changeset/operations/contracts/deploy_configure_forwarders_seq.go # deployment/vault/changeset/transfer_from_datastore.go
|
I see you updated files related to
|
There was a problem hiding this comment.
Pull request overview
Risk Rating: HIGH
This PR migrates ownership-transfer / MCMS config-related deployment logic away from in-repo changesets/opsutils and onto cld-changesets (and bumps several dependency versions), reducing duplicated implementations across repos.
Changes:
- Replaced in-repo “transfer ownership / set config” changeset & opsutils usages with
cld-changesetsequivalents (incl. updated import paths likepkg/cldfutil/...andlegacy/mcms/...). - Removed now-redundant in-repo EVM MCMS ops/sequences + some proposalutils test helpers.
- Updated multiple Go modules and plugin refs to align with the new dependency surface (e.g.,
cld-changesets v0.4.0,mcms v0.43.0,go-ethereum v1.17.3,grpc v1.81.0, updatedchainlink-tongitRef).
Scrupulous human review recommended for:
- All ownership-transfer paths now routed through
cld-changesets(TransferToMCMSWithTimelockV2,RenounceTimelockDeployer,LoadOwnableContract) to ensure behavior parity (especially “only accept ownership” and proposal/no-send flows). - EVM operation/sequence type migrations to
cld-changesets/pkg/family/evm/operations(EVMCallInput/EVMCallOutput,ContractOpts, ownership ops) to ensure field/semantics compatibility. - TON MCMS state adaptation in
deployment/ccip/changeset/cs_orchestrate_changesets.goto ensure proposal aggregation receives complete/accurate TON state.
Reviewed changes
Copilot reviewed 132 out of 139 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/smoke/cre/sharding_test.go | Switch CLD changeset helper import to cldfutil/changeset. |
| system-tests/tests/smoke/cre/por_helpers.go | Switch CLD changeset helper import to cldfutil/changeset. |
| system-tests/tests/go.mod | Bump deps (geth, deployments-framework, cld-changesets, aws sdk, mcms, lo). |
| system-tests/lib/go.mod | Bump deps (geth, deployments-framework, cld-changesets, aws sdk, mcms, lo). |
| system-tests/lib/cre/contracts/contracts.go | Switch CLD changeset helper import to cldfutil/changeset. |
| plugins/plugins.public.yaml | Update chainlink-ton plugin gitRef. |
| integration-tests/smoke/ccip/ccip_cs_update_rmn_config_test.go | Use cld-changesets MCMS changesets for ownership transfer. |
| integration-tests/smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go | Use cld-changesets MCMS changesets/types. |
| integration-tests/smoke/ccip/ccip_add_chain_test.go | Use cld-changesets MCMS changesets for transfer/renounce. |
| integration-tests/smoke/ccip/ccip_add_chain_e2e_test.go | Use cld-changesets MCMS changesets for ownership transfer. |
| integration-tests/load/go.mod | Bump deps (geth, deployments-framework, cld-changesets, aws sdk, mcms, lo). |
| integration-tests/go.mod | Bump deps (geth, deployments-framework, cld-changesets, aws sdk, mcms, lo). |
| go.mod | Bump deps (geth, gethwrappers, chainlink-ton, quarantine, grpc, lo). |
| go.md | Update dependency graph edges to reflect new relationships. |
| deployment/vault/changeset/transfer_from_datastore.go | Swap ownership transfer implementation to cld-changesets MCMS changeset. |
| deployment/keystone/changeset/operations/contracts/deploy_configure_forwarders_seq.go | Replace in-repo MCMS ops/seqs usage with cld-changesets operations + helpers. |
| deployment/keystone/changeset/accept_ownership.go | Swap ownership transfer implementation to cld-changesets MCMS changeset. |
| deployment/go.mod | Bump deps (geth, deployments-framework, cld-changesets, aws sdk, mcms, lo). |
| deployment/data-feeds/view/v1_0/cache_contract.go | Switch CLD util import to pkg/cldfutil. |
| deployment/data-feeds/changeset/update_data_id_proxy_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/set_feed_config_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/set_feed_admin_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/set_bundle_feed_config_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/remove_feed_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/remove_feed_config_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/remove_dataid_proxy_mapping_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/propose_aggregator_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/new_feed_with_proxy.go | Switch changeset + ownable loader to cld-changesets packages. |
| deployment/data-feeds/changeset/new_feed_with_proxy_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/confirm_aggregator_test.go | Use cld-changesets MCMS changesets in tests. |
| deployment/data-feeds/changeset/accept_ownership.go | Switch ownable loader to cld-changesets MCMS changesets. |
| deployment/cre/mcms/changeset/configure.go | Switch MCMS config changeset call to cld-changesets. |
| deployment/cre/contracts/contracts_test.go | Use cld-changesets MCMS changesets for ownership transfer in tests. |
| deployment/common/view/v2_0/capreg.go | Switch CLD util import to pkg/cldfutil. |
| deployment/common/view/v2_0/capreg_test.go | Switch CLD util import to pkg/cldfutil. |
| deployment/common/view/v1_0/workflowreg.go | Switch CLD util import to pkg/cldfutil. |
| deployment/common/view/v1_0/mcms.go | Switch CLD util import to pkg/cldfutil. |
| deployment/common/view/v1_0/capreg.go | Switch CLD util import to pkg/cldfutil. |
| deployment/common/view/v1_0/capreg_test.go | Switch CLD util import to pkg/cldfutil. |
| deployment/common/proposalutils/propose_test.go | Deleted (proposal build testing moved/removed). |
| deployment/common/proposalutils/mcms_test_helpers.go | Deleted (helpers moved to deployments-framework testhelpers). |
| deployment/common/opsutils/evm.go | Update sequence output typing to cld-changesets EVM operations output. |
| deployment/common/opsutils/evm_test.go | Update tests to cld-changesets EVM operations output type. |
| deployment/common/changeset/state/pda.go | Deleted (PDA helpers removed from in-repo changesets). |
| deployment/common/changeset/evm/mcms/seqs/seq_transfer_to_mcms_timelock.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/seqs/seq_mcm_with_config.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/seqs/seq_grant_roles_for_timelock.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/ops/ops_transfer_accept_ownership.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/ops/ops_timelock_deploy.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/ops/ops_mcm_set_config.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/ops/ops_mcm_deploy.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/ops/ops_grant_role.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/ops/ops_callproxy_deploy.go | Deleted (replaced by cld-changesets). |
| deployment/common/changeset/evm/mcms/mcms.go | Switch timelock role-grant sequence to cld-changesets sequences/outputs. |
| deployment/common/changeset/evm/approve_token.go | Switch CLD changeset import to cldfutil/changeset. |
| deployment/ccip/view/v1_6/rmnremote.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_6/rmnhome.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_6/onramp.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_6/offramp.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_6/noncemanager.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_6/feequoter.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_6/ccip_home.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_5/tokenadminregistry.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_5/token_pool.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_5/rmn.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_5/onramp.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_5/offramp.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_5/commit_store.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_5_1/token_pool.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_2/router.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_2/price_registry.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/view/v1_0/rmn_proxy_contract.go | Switch CLD util import to pkg/cldfutil. |
| deployment/ccip/shared/stateview/state.go | Switch Ownable typing + ownership validation helpers to cld-changesets. |
| deployment/ccip/shared/stateview/state_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/shared/deployergroup/deployer_group_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/sequence/evm/v1_6/seq_update_lanes.go | Switch sequence outputs/input types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_6/seq_router.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_6/seq_rmn.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_6/seq_onramp.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_6/seq_offramp.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_6/seq_nonce_manager.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_6/seq_fee_quoter.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_6/seq_deploy_chain.go | Switch deploy/call inputs + retry helpers to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_6/seq_ccip_home.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_5_1/seq_hybrid_token_pool.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/v1_5_1/seq_fast_transfer_token_pool.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/sequence/evm/seq_erc677_token.go | Switch call input/output types to cld-changesets EVM operations. |
| deployment/ccip/operation/evm/v1_6/ops_rmnremote.go | Switch deploy/call ops to cld-changesets EVM operations helpers. |
| deployment/ccip/operation/evm/v1_6/ops_onramp.go | Switch deploy/call ops to cld-changesets EVM operations helpers. |
| deployment/ccip/operation/evm/v1_6/ops_offramp.go | Switch deploy/call ops to cld-changesets EVM operations helpers. |
| deployment/ccip/operation/evm/v1_6/ops_nonce_manager.go | Switch deploy/call ops to cld-changesets EVM operations helpers. |
| deployment/ccip/operation/evm/v1_6/ops_fee_quoter.go | Switch deploy/call ops to cld-changesets EVM operations helpers (partial). |
| deployment/ccip/operation/evm/v1_6/ops_ccip_home.go | Switch call ops to cld-changesets EVM operations helpers. |
| deployment/ccip/operation/evm/v1_5_1/ops_hybrid_token_pool.go | Switch call ops to cld-changesets EVM operations helpers. |
| deployment/ccip/operation/evm/v1_5_1/ops_fast_transfer_token_pool.go | Switch call ops to cld-changesets EVM operations helpers. |
| deployment/ccip/operation/evm/v1_2/ops_router.go | Switch deploy/call ops to cld-changesets EVM operations helpers. |
| deployment/ccip/operation/evm/ops_erc677_token.go | Switch ERC677 “grant roles” op to cld-changesets EVM operations helper. |
| deployment/ccip/changeset/v1_6/cs_update_rmn_config.go | Switch EVM call input type to cld-changesets EVM operations. |
| deployment/ccip/changeset/v1_6/cs_update_bidirectional_lanes.go | Switch EVM call input types to cld-changesets EVM operations. |
| deployment/ccip/changeset/v1_6/cs_update_bidirectional_lanes_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/v1_6/cs_translate_onramp_to_feequoter.go | Switch EVM call input types to cld-changesets EVM operations. |
| deployment/ccip/changeset/v1_6/cs_translate_onramp_to_feequoter_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/v1_6/cs_migration_from_v1_5.go | Switch ownership checks/transfers to cld-changesets (and legacy Ownable type). |
| deployment/ccip/changeset/v1_6/cs_migration_from_v1_5_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/v1_6/cs_home_chain_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/v1_6/cs_deploy_chain_test.go | Switch deploy opts typing to cld-changesets ContractOpts. |
| deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e.go | Switch ownership transfer/renounce + Ownable typing to cld-changesets. |
| deployment/ccip/changeset/v1_6/cs_add_new_chain_e2e_test.go | Update tests to use cld-changesets Ownable + MCMS changesets. |
| deployment/ccip/changeset/v1_6/cs_active_candidate_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/v1_6/accept_ownership_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/v1_6_2/cs_configure_usdc_token_pool.go | Switch call op + seq output integration to cld-changesets EVM ops. |
| deployment/ccip/changeset/v1_6_2/cs_configure_cctp_message_transmitter_proxy.go | Switch call op + seq output integration to cld-changesets EVM ops. |
| deployment/ccip/changeset/v1_5_1/cs_sync_usdc_domains_with_chains_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/v1_5_1/cs_set_token_transfer_fee_config_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/v1_5_1/cs_hybrid_token_pool_groups.go | Switch EVM call input types to cld-changesets EVM ops. |
| deployment/ccip/changeset/v1_5_1/cs_fast_transfer_token_pools.go | Switch EVM call input types to cld-changesets EVM ops. |
| deployment/ccip/changeset/v1_5_1/cs_add_token_e2e.go | Switch transfer + EVM call input to cld-changesets packages. |
| deployment/ccip/changeset/v1_5_1/cs_add_token_e2e_test.go | Update tests to use cld-changesets MCMS changesets. |
| deployment/ccip/changeset/testhelpers/test_token_helpers.go | Switch helper generic bound to legacy evm.Ownable + MCMS changesets. |
| deployment/ccip/changeset/testhelpers/test_helpers_solana_v0_1_0.go | Switch CLD common changeset import + MCMS transfer config type. |
| deployment/ccip/changeset/testhelpers/test_environment.go | Replace proposalutils helper usage with deployments-framework testhelpers types. |
| deployment/ccip/changeset/testhelpers/test_assertions.go | Switch ownable loader to cld-changesets MCMS changesets. |
| deployment/ccip/changeset/cs_orchestrate_changesets.go | Add TON MCMS state adapter for proposal aggregation. |
| deployment/ccip/changeset/cs_grant_and_mint_link_token.go | Switch ERC677 role grant calls to cld-changesets EVM call input type. |
| deployment/ccip/changeset/crossfamily/cs_set_token_transfer_fee_config_test.go | Update tests to use cld-changesets MCMS changesets. |
| core/scripts/go.mod | Bump deps (geth, deployments-framework, cld-changesets, aws sdk, mcms, lo). |
| SetRMNRemoteOnRMNProxySequence = operations.NewSequence( | ||
| "SetRMNRemoteOnRMNProxySequece", | ||
| semver.MustParse("1.0.0"), |
cld-changesets